Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove show new post notifs setting. #2675

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Remove show new post notifs setting. #2675

merged 1 commit into from
Aug 27, 2024

Conversation

dessalines
Copy link
Member

SleeplessOne1917
SleeplessOne1917 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We should also remove the i18n key for this in the translations repo assuming it's no longer used anywhere.

@SleeplessOne1917 SleeplessOne1917 merged commit d4b6f29 into main Aug 27, 2024
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the remove_show_new_post_notifs branch August 27, 2024 19:00
@dessalines
Copy link
Member Author

@Nutomic got that key removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

@matc-pub matc-pub Awaiting requested review from matc-pub matc-pub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Show Notifications for New Posts doesn't seem to do anything
2 participants
@dessalines @SleeplessOne1917