Remove min and max length from password input when using login form #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,8 +99,10 @@ class PasswordInput extends Component<PasswordInputProps, PasswordInputState> { | |||
| onInput={onInput} | |||
| value={value} | |||
| required | |||
| pattern=".{10,60}" | |||
| pattern=".+" | |||
There was a problem hiding this comment.
I changed the pattern since length is all we're checking for and min and max length gives more information to users as to what is wrong than using the pattern.
dessalines
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2381 using @richardARPANET 's suggestion.
Something I noticed working on this is that whitespace is allowed in passwords. This doesn't seem a problem in and of itself, but it's possible to make a password entirely from whitespace. Should this be allowed?