Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue from logo bugfix #2620

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Fix issue from logo bugfix #2620

merged 3 commits into from
Jul 22, 2024

Conversation

SleeplessOne1917
Copy link
Member

The should address the issue @phiresky pointed out in the previous PR for the logo bugfix.

} catch (e) {
console.log(
`Failed to fetch site logo for manifest icon. Using default icon`,
);
icons = generateDeafultIcons();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. Will fix.

@SleeplessOne1917 SleeplessOne1917 enabled auto-merge (squash) July 22, 2024 14:17
@SleeplessOne1917 SleeplessOne1917 merged commit 5c3da58 into main Jul 22, 2024
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the broken-logo-2 branch October 2, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants