Added aspect ratio to the videos #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismailkarsli
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
dessalines
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
https://getbootstrap.com/docs/5.0/helpers/ratio/
Seems fine as a kludge for now.
I spose that'd be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vertical videos are sometimes 2 times bigger than window height. This is very disturbing in terms of UX. I added 16x9 ratio, if there is no other overlooked reason, can you peep accept it?
Screenshots
Before
After
Apart from this issue
When watching videos in sequence, they all start muted, even we set a volume in previous video.
Do you think it makes sense to store the previous volume value in globalThis and use that value while in the same session?