Disable "Next" button in Paginator when the next page is empty #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noskla
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
…th of the array, not the array itself
noskla
changed the title
SleeplessOne1917
approved these changes
Sep 4, 2023
dessalines
reviewed
Sep 4, 2023
…tsx and modlog.tsx
| @@ -23,6 +24,7 @@ export class Paginator extends Component<PaginatorProps, any> { | |||
| <button | |||
| className="btn btn-secondary" | |||
| onClick={linkEvent(this, this.handleNext)} | |||
| disabled={this.props.nextDisabled || false} | |||
There was a problem hiding this comment.
Is the || false necessary here?
There was a problem hiding this comment.
Good catch, it's a residue after nextDisabled was optional to not pass "undefined" to the property, I'll fix it
| <Paginator | ||
| page={this.state.page} | ||
| onChange={this.handlePageChange} | ||
| nextDisabled={false} |
There was a problem hiding this comment.
Is there never a time that this needs to be disabled?
There was a problem hiding this comment.
It needs to be disabled when there are multiple lists (because the API doesn't combine them)
| <Paginator | ||
| page={page} | ||
| onChange={this.handlePageChange} | ||
| nextDisabled={false} |
SleeplessOne1917
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It may cause confusion to the user why pages in the community list are empty when there are no more communities to display. This small change fixes this issue by disabling the Next button if the number of fetched communities is less than the limit.
Additionally, I have moved the communityLimit constant to the config file.
Possible issues with this approach
The Next button will be still enabled, if there are exactly {communityLimit} communities on the instance, to mitigate this the API would have to tell the client if currently viewed page is last, or the client could fetch next page in advance.