always show community name with instance for easy copy-pasting to friends #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ends I don't like the inconsistency of community names currently, the UI shouldn't be presenting things differently because of technical reasons that are hard for users to understand. This makes it easier to share communities with your friends!
Die4Ever
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
SleeplessOne1917
approved these changes
Aug 24, 2023
camporter
reviewed
Aug 30, 2023
dessalines
approved these changes
Aug 30, 2023
| title = `${community.title}@${domain}`; | ||
| link = !this.props.realLink ? `/c/${name_}` : community.actor_id; | ||
| } | ||
|
|
||
| const apubName = `!${name_}`; | ||
| const apubName = `!${community.name}@${domain}`; |
There was a problem hiding this comment.
This should be okay, because it should only use the apubName on community pages, hopefully not in most community links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't like the inconsistency of community names currently, the UI shouldn't be presenting things differently because of technical reasons that are hard for users to understand. This makes it easier to share communities with your friends!
Screenshots
Before
After