Use the 'node' user instead of root while running in a container #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camporter
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
Nutomic
approved these changes
Jul 10, 2023
SleeplessOne1917
approved these changes
Jul 10, 2023
dessalines
approved these changes
Jul 10, 2023
dessalines
pushed a commit
that referenced
this pull request
Jul 10, 2023
makotech222
added a commit
to hexbear-collective/lemmy-ui
that referenced
this pull request
Jul 13, 2023
)" This reverts commit 462bdb1.
|
This one killed my 'docker compose up' run on our server, just fyi. dunno why, just removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than running lemmy-ui as the root user in the container, run it as the
nodeuser provided by the node runner image.Screenshots
N/A
Before
The
nodeprocess runs asroot, which should be avoided if possible.After
The
nodelemmy-ui process runs as thenodeuser.