Use Join Lemmy hostname as link text in footer #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnswrsrx
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
SleeplessOne1917
approved these changes
Jul 1, 2023
|
Please export a string from |
Ah, I should have looked a bit more to see if there was the URL hardcoded somewhere! Using the |
alectrocute
approved these changes
Jul 1, 2023
dessalines
reviewed
Jul 3, 2023
dnswrsrx
changed the title
I think it makes sense to keep a link to the Join Lemmy website even though there's a logged in user. There's plenty of other useful info on that website beyond just joining Lemmy. Using the URL avoids the phrase "Join Lemmy" and should indicate that you're navigating to said website.
To maintain consistency whether logged in or not.
dnswrsrx
force-pushed
the
footer_join_lemmy
branch
from
dab9e64 to
5b41ce7
Compare
dessalines
approved these changes
Jul 4, 2023
dessalines
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to keep a link to the Join Lemmy website even though there's a logged in user. There's plenty of other useful info on that website beyond just joining Lemmy.
Using the URL avoids the phrase "Join Lemmy" and should indicate that you're navigating to said website.
Should address issue #1723