Fix DM replies not working #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunaurus
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
alectrocute
approved these changes
Jul 1, 2023
SleeplessOne1917
approved these changes
Jul 1, 2023
4 tasks
|
@sunaurus Thank you so much for this, this was my regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PrivateMessageFormdecides whether it's being used for editing a DM or replying to a DM based on whetherprivateMessageViewisundefined.Currently in rc7, replying to private messages is impossible, as
privateMessageViewis passed in even when replying. Clicking the reply icon opens up an edit form, and saving this edit form generates an error (because you can't edit another person's DM).This PR fixes the bug by removing
privateMessageViewfrom replies.