Add fallback date-fns locale import #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunaurus
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
SleeplessOne1917
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This date-fns locale bug is like a bossfight with multiple phases... hopefully this is the last phase 😅
Previously I fixed:
xx-XX(eg:fr-FR) failing to work, because for these date-fns expects justxxFix date-fns locale import failing for some locales #1721These fixed the problem for most users, but turns out there are some locales out there which date-fns simply doesn't have support for. One example:
es-MX. For these users, the import still fails and Lemmy is still broken.This PR adds a fallback import of
en-USwhen the user's locale is not availabe in date-fns.