Cache static data for a day #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
requested review from
dessalines,
alectrocute and
jsit
as code owners
alectrocute
reviewed
Jun 29, 2023
| @@ -24,7 +24,7 @@ export async function createSsrHtml( | |||
|
|
|||
| if (!appleTouchIcon) { | |||
| appleTouchIcon = site?.site_view.site.icon | |||
| ? `data:image/png;base64,${sharp( | |||
| ? `data:image/png;base64,${await sharp( | |||
alectrocute
reviewed
Jun 29, 2023
src/server/middleware.ts
Outdated
| if (user.auth()) { | ||
| caching = "private"; | ||
| } else { | ||
| caching = "public, max-age=60"; |
There was a problem hiding this comment.
Would changing max-age here to 5 fix/mitigate our captcha and logout issues?
There was a problem hiding this comment.
Not sure. I left a comment on your other PR about the Clear-Site-Data header. That would require a change to the js client instead of the UI, but it could help. The only rub is that the cache option of site data is not supported in Firefox.
|
I say we change the |
alectrocute
approved these changes
Jun 29, 2023
dessalines
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets cache control for static content.