Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen PR 1420 Feature add three six and nine months options frontend #1689

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Reopen PR 1420 Feature add three six and nine months options frontend #1689

merged 8 commits into from
Jul 7, 2023

Conversation

c-andy-candies
Copy link
Contributor

This reopens #1420 which was closed by mistake

@L3v3L
Copy link
Contributor

L3v3L commented Jun 29, 2023

don't stress, you're doing great.
The woodpecker is not passing because of the same situation here:
#1345 (comment)

@L3v3L
Copy link
Contributor

L3v3L commented Jun 29, 2023

@dessalines this requires that this repo point to a new version of LemmyNet/lemmy-js-client

@L3v3L
Copy link
Contributor

L3v3L commented Jun 29, 2023

@c-andy-candies once @dessalines has updated the version, you need to send an empty commit to this branch, it will trigger the woodpecker to rerun.

@dessalines dessalines enabled auto-merge (squash) June 29, 2023 20:57
@c-andy-candies
Copy link
Contributor Author

@L3v3L Do I need to do something else? I thought LemmyNet/lemmy-js-client#153 added the required sorting options

@L3v3L
Copy link
Contributor

L3v3L commented Jul 7, 2023

@L3v3L Do I need to do something else? I thought LemmyNet/lemmy-js-client#153 added the required sorting options

They've just updated.
The issue was: in this repo the package.json was still pointing to an older version of lemmy-js-client.
Woodpecker should now not complain about that issue. (You will need to trigger a new woodpecker run, either merge the new changes as you've been doing, or commit an empty commit)

@dessalines dessalines merged commit 214eae5 into LemmyNet:main Jul 7, 2023
dessalines added a commit that referenced this pull request Jul 10, 2023
…#1689)

Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants