Add space between cancel and ban button #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascaldevink
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
dessalines
requested changes
Jun 26, 2023
| @@ -693,6 +693,7 @@ export class Profile extends Component< | |||
| > | |||
| {I18NextService.i18n.t("cancel")} | |||
| </button> | |||
There was a problem hiding this comment.
Just add mb-3 to the button, not adding a pointless row like this.
There was a problem hiding this comment.
You're right, I made an empty new row, where I meant to put the button in a new row 🤦 Fixed that
|
Rather than adding an empty div, put a margin bottom and display block on the existing button. |
When banning a user, the modal has two buttons: cancel and ban. These buttons are so close to each other that it's hard to see they are separate buttons. By putting each button on their own row, there is more space between them.
pascaldevink
force-pushed
the
create_space_between_cancel_and_ban_button
branch
from
61d13f8 to
6dc9c63
Compare
SleeplessOne1917
approved these changes
Jun 26, 2023
alectrocute
approved these changes
Jun 26, 2023
dessalines
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When banning a user, the modal has two buttons: cancel and ban. These buttons are so close to each other that it's hard to see they are separate buttons.
By putting each button on their own row, there is more space between them.
Before:
After:
