Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Fix non-unique ID attribute on re-used element #1568

Merged
merged 2 commits into from
Jun 25, 2023
Merged

fix(a11y): Fix non-unique ID attribute on re-used element #1568

merged 2 commits into from
Jun 25, 2023

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jun 24, 2023

This element appears multiple times on a page, so it needs to be a unique ID

@jsit jsit changed the title fix: Fix non-unique ID attribute on re-used element fix(a11y): Fix non-unique ID attribute on re-used element Jun 24, 2023
@SleeplessOne1917 SleeplessOne1917 merged commit 2381db2 into LemmyNet:main Jun 25, 2023
@jsit jsit deleted the fix/fix-dropdown-id-unique branch June 25, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

@alectrocute alectrocute Awaiting requested review from alectrocute

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsit @SleeplessOne1917