Remove scroll position set/get for Community and Home
#1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alectrocute
requested review from
dessalines and
SleeplessOne1917
as code owners
|
@SleeplessOne1917 This seems like a pretty big deal. Is this how we should resolve it? Is there any reason to restore scroll position on these specific routes? |
| @@ -1,5 +1,6 @@ | |||
| export default function restoreScrollPosition(context: any) { | |||
There was a problem hiding this comment.
Are this and saveScrollPosition still used?
There was a problem hiding this comment.
Yep, on Profile, Search, and Post.
SleeplessOne1917
approved these changes
Jun 22, 2023
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lemdevs!
Pretty grave bug here with our scrolling:
Untitled.mov
This used to not be a problem in 0.17 because our routes were different, eg.
https://sh.itjust.works/home/data_type/Post/listing_type/Local/sort/Active/page/2vs. query params.I propose we:
CommunityandHome, eg. routes where pagination is a critical and frequently used part of the view