Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix too-intense hr color between posts #1376

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jun 18, 2023

#1304 used the primary color for horizontal rules, which looks subtle-ish on dark mode, but less subtle on light mode.

It also increased the border width of the <hr>s.

This PR makes the colors more subtle, while still being visible, and modifies the Bootstrap hr-border-color variable for more global <hr> color fixing.

Would like feedback from @ayan4m1 and @SleeplessOne1917 on this, as they were responsible for the previous fix.

Before

Screenshot 2023-06-18 at 3 43 29 PM Screenshot 2023-06-18 at 3 43 20 PM

After

Screenshot 2023-06-18 at 3 37 25 PM Screenshot 2023-06-18 at 3 37 36 PM

Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SleeplessOne1917 SleeplessOne1917 merged commit 5f8a181 into LemmyNet:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants