Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Fix some a11y issues in Site Sidebar and use native Bootstrap Collapse and Card classes #1355

Merged
merged 12 commits into from
Jun 18, 2023
Merged

fix(a11y): Fix some a11y issues in Site Sidebar and use native Bootstrap Collapse and Card classes #1355

merged 12 commits into from
Jun 18, 2023

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jun 17, 2023 •
edited
Loading

Fix some a11y issues in Site Sidebar and use native Bootstrap Collapse and Card classes

Should note that this changes / standardizes the way these sidebar cards look:

Before

Screenshot 2023-06-17 at 3 34 09 PM Screenshot 2023-06-17 at 3 34 05 PM

After

Screenshot 2023-06-17 at 3 33 07 PM Screenshot 2023-06-17 at 3 33 20 PM

SleeplessOne1917
SleeplessOne1917 approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the nitpick change if you want, but it's not a big enough deal to keep me from approving.

@SleeplessOne1917 SleeplessOne1917 merged commit ad0c24f into LemmyNet:main Jun 18, 2023
@jsit jsit mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsit @SleeplessOne1917