feat: Add Badges common component #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-component * origin/main: handle login failures correctly wrap login call in try/catch for error handling Remove extra div in post sidebar Add a class to the more button on a comment node Switch navbar classes to ids Adding a few more 0.18.0 API changes. (LemmyNet#1324) Use aside semantic HTML tag for sidebars Use article semantic HTML tag for posts/comments Use footer semantic HTML tag Adding codeowners. Add lemmy-site class for easier detection Add ID's and classes to sidebars Add clases and ID's to post form/listing Add classes to post and comment repy textareas Rename markdown-textarea ID's Add nav and footer ID's
SleeplessOne1917
approved these changes
Jun 17, 2023
|
@jsit fix the lint error and this is good to merge. |
auto-merge was automatically disabled
June 17, 2023 02:25
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizing "Badges" into a common component here. Should show no visible change to end user.
Before
After