fix loading custom themes with a custom LEMMY_UI_EXTRA_THEMES_FOLDER #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should definitely wait until #1322 is merged to implement this fix. |
Sure, I'll just be using a patch file for now. |
|
Okay I’ll rework this in a sec! |
SleeplessOne1917
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least when using the
LEMMY_UI_EXTRA_THEMES_FOLDERenvironment variable, themes do correctly appear in the list (nice), but when trying to use them, they unfortunately default to litely. This fixes it.Please note: I haven't, and can't really test loading themes without a custom folder, but if this works, then the changes I made here should still work. Do test it though.