Admin Settings: Bugfixes #1313
Merged
Admin Settings: Bugfixes #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me labels, add missing bind
alectrocute
requested review from
dessalines and
SleeplessOne1917
as code owners
alectrocute
commented
Jun 15, 2023
| @@ -73,6 +73,7 @@ export class Setup extends Component<any, State> { | |||
| onSaveSite={this.handleCreateSite} | |||
| siteRes={this.state.siteRes} | |||
| themeList={this.state.themeList} | |||
| loading={false} | |||
There was a problem hiding this comment.
This can always be false since the route is redirected upon submit of this form.
…alectrocute/lemmy-ui into admin-settings-bugfixes-and-tlc
dessalines
reviewed
Jun 16, 2023
|
Thanks for the feedback, @dessalines! I've implemented the changes. |
dessalines
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lemdevs!
This PR addresses some outstanding bugs in our admin settings panel –
handleRemoveInstance(ugh, I hate we have to do this!)loadingstate toAdminSettings, pass as prop to all children, which resolves some infinite loading issuesThanks!