Set html lang attr to the interface language #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
approved these changes
Jun 11, 2023
|
Just rebased onto main so that the CI would pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1168
As there are issues with running the main branch with the current backend repo, I tested this by cherry-picking to
use_http_client_2.My change fixes the linked issue by setting the
langattribute of thehtmltag properly in accordance to the lemmy user preferences or user-agent preferences. If the lemmy user has a UI language other than "Browser" set, then the response from the server will already have the correctlangset. Otherwise the attr is set on the client side according to the language settings in the browser. If any of this fails, it falls back to English.