fix: Adds ability to hide language warning #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skspade
force-pushed
the
1078-language-select-disable-warning
branch
2 times, most recently
from
c9a2a43 to
1193d5b
Compare
|
I think I've seen this warning in places other than just the community form. Can you check the other places the languages select component is used to make sure it's not showing up in other places it doesn't belong? |
|
Certainly! Since I'm new to Lemmy, can you elaborate on where it doesn't belong? Or if it's easier, tell me where it does belong |
|
I am thinking it should only show on the settings screen for the user? Aka |
Correct. |
|
Then I'll probably swap the boolean to make it |
skspade
force-pushed
the
1078-language-select-disable-warning
branch
from
1193d5b to
23c4b68
Compare
|
Should be good to go whenever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe
Community form should not show
undetermined_language_warningwarning. Since the component is shared between multiple forms ahideLanguageWarningprop was added so a specific instance can hide it.Screenshot
Ticket
Closes #1078