Redirect from pages that require auth on logout #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/shared/services/UserService.ts
Outdated
| @@ -48,7 +48,15 @@ export class UserService { | |||
| this.myUserInfo = undefined; | |||
| IsomorphicCookie.remove("jwt"); // TODO is sometimes unreliable for some reason | |||
| document.cookie = "jwt=; Max-Age=0; path=/; domain=" + location.hostname; | |||
| location.reload(); | |||
| if ( | |||
| /create_.*|inbox|settings|setup|admin|reports|registration_applications/g.test( | |||
There was a problem hiding this comment.
It might be worth extracting this into a function and putting it in utils. It would help with what I called out on another PR.
SleeplessOne1917
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't make an issue for this one, but the code change does what the PR title says. Currently, if a user logs out of their account while on a page that requires auth (like /settings, /admin, /inbox, etc), they will not be navigated away from the page.