-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for video embeds #709
Comments
I'm confused, is it possible to emebd a video link already or is this still work in progress (0.16.6)? |
This will be part of 0.17.0 |
That PR does add support for video embeds from peertube, but we also need to support pictrs videos. |
Could you also support onlineplayer.com? This video player can be iframe-embedded like youtube or vimeo, but can play video files hosted elsewhere, like dropbox or discord. Right now using this has video controls briefly show up but then gives the "no video with supported mime type found" error. |
please add support for direct links to videos to be played back on site. a lot of us are all about self hosted and that includes our storage! i have a seafile and i host meme videos on it. these embed in things like Discord without issues would be nice for lemmy to also support it. example url: https://seafile.kitsuna.net/f/ffb48fd595a34e3b8b0a/?raw=1 |
Would like to see this feature as well for posts and comments. This will allow posts and comments to embed multiple videos in a post or comment. Would be great if youtube, peertube and odysee was supported for video sites! |
I agree, @lordkitsuna. I believe that the title should be updated to reflect that. |
Yea would be nice to have feature to add code provided by video hosting. There are plenty of regional video platforms besides YouTube! |
Video embeds are discovered using Opengraph attribute, there is no specific logic for Youtube. So it should work with any platform which provides these attributes. |
Is there any docs regarding ogp embedding on lemmy? just looking for examples to make it work My case is this ogp -- it's a mastodon post, not a video. I'd like to display preview either in the body or a comment of lemmy post preview should look ~ like that
source for the ogp: https://shkspr.mobi/blog/2022/11/webmentions-privacy-and-ddos-oh-my/ |
lemmy stores some embed info, and lemmy-ui currently shows a metadata card containing the embed title and description, if the back-end was able to fetch and store them correctly. |
Are you supposed to be able to play a PeerTube video, directly on Lemmy? Because it seems that it only gets a thumbnail and then a link to the PeerTube instance. |
Yes that should be working, but it does need some people to help test. |
Maybe we are misunderstanding each other, but if you go here https://lemmy.wtf/c/gametrailers I am not able to play the videos from PeerTube. I have to go directly to Peertube to play the video. |
Same goes for https://sh.itjust.works/c/thelinuxexperiment_channel@tilvids.com. |
This change removed API field post.embed_html, and added embed_url instead. This should work for Youtube, Peertube and and other sites that set the opengraph attribute in their html.
So lemmy-ui should show a video embed whenever that field is set. At the moment the implementation is a bit strange, because it only shows the embed if post.embed_title is set, which isnt always the case. I would also suggest to change the "plus" button behind which the embed is hidden, because its not clear at all what it does. Maybe just change it to a text label "watch video".
The text was updated successfully, but these errors were encountered: