-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS styles for min-width beyond 1200px #1536
Comments
I started toying around with this at one point. I received some feedback that would need to be considered if the left pane is going to take up most of the space: how do we keep a good line length and make it look right when dealing with posts and comments? |
I'm working on this now. |
There's many issues with the basic layout of lemmy besides bugs like collapsed comments re-appearing once you load new comments. It's too spaced out, and doesn't give enough space for the important part - posts and comments. This modification goes in the right direction: https://github.com/soundjester/lemmy_monkey Also consider this comment: https://news.ycombinator.com/item?id=36413856 Things I noticed:
When in doubt, look at the design principles of Reddit, especially Old Reddit. Reddit has spent a lot of time on thinking about which information to highlight so that users can focus on the actual content and discussion. Lemmy wastes a lot of users' attention on unnecessary things which makes it very tiring to focus on the actual discussions and content. |
@blox814123, given the current situations with mass migrations, I think short-term fixes are the best route forward, and longer-term refactors can be considered later. Just fix the glaring UI issues first. |
fix(UI): Make max-width wider, and make sidebar narrower on wide screens (#1536)
Requirements
Describe the feature you'd like
I've got a browser window width spanning just over 2500 pixels. The existing
@media (min-width: 1200px)
styles are rather limiting, considering how.container
and its mates are forced to amax-width
of1140px
. So, over half of my browser window on the front page is empty space.Just getting rid of the
max-width
on the CSS solves part of it. But, there's also other.col-*
properties that could re-adjusted with theirflex
andmax-width
columns. The right-pane needs to be shrunk, possibly even to a fix size of 300px or so, and the left-pane expanded as far as it can.The text was updated successfully, but these errors were encountered: