refactor: 초대장 생성/상세조회 요청, 응답 DTO 수정 및 초대장 엔티티 추가 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results31 files 31 suites 2s ⏱️ Results for commit 7c975a2. ♻️ This comment has been updated with latest results. |
yechan-kim
reviewed
Feb 2, 2025
...ructure/persistence-db/src/main/kotlin/site/yourevents/invitation/entity/InvitationEntity.kt
Outdated
Show resolved
Hide resolved
...entation/src/main/kotlin/site/yourevents/invitation/dto/response/CreateInvitationResponse.kt
Outdated
Show resolved
Hide resolved
yechan-kim
requested changes
Feb 3, 2025
module-domain/src/main/kotlin/site/yourevents/guest/port/in/GuestUseCase.kt
Outdated
Show resolved
Hide resolved
module-domain/src/main/kotlin/site/yourevents/guest/port/out/GuestPersistencePort.kt
Outdated
Show resolved
Hide resolved
...ucture/persistence-db/src/main/kotlin/site/yourevents/guest/repository/GuestJPARepository.kt
Outdated
Show resolved
Hide resolved
...esentation/src/main/kotlin/site/yourevents/invitation/dto/response/InvitationInfoResponse.kt
Outdated
Show resolved
Hide resolved
jwnnoh
reviewed
Feb 3, 2025
...ucture/persistence-db/src/main/kotlin/site/yourevents/guest/repository/GuestJPARepository.kt
Outdated
Show resolved
Hide resolved
module-presentation/src/main/kotlin/site/yourevents/invitation/facade/InvitationFacade.kt
Show resolved
Hide resolved
yechan-kim
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR 유형
어떤 변경 사항이 있었나요?
✏️ 작업 내용
**클라이언트 측의 요청에 따라 초대장 생성 기능에서 응답 DTO의 경우 invitationID만 반환되도록 수정하였습니다.
**InvitationEntity에 templateKey Column을 추가하였으며 null값을 허용하였습니다. **
다음과 같이 값을 넣어도, 아무것도 넣지 않아도(null) 잘 동작하게 구현하였습니다.
다음과 같이 초대장 상세조회에도 templateKey가 나타나도록 구현하였습니다.
🔗 관련 이슈
💡 추가 사항
클라이언트 측 추가 요구사항으로 초대장 상세조회 Response 값에 초대장 생성자의 nickname을 추가하였습니다.
