refactor: presigned url VO 삭제 및 yml 파일 통합

Leets-Official · Jan 18, 2025 · 43be920 · 43be920
1 parent a84dbd0
commit 43be920
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 32 deletions.
diff --git a/module-domain/src/main/kotlin/site/yourevents/s3/port/in/PreSignedUrlUseCase.kt b/module-domain/src/main/kotlin/site/yourevents/s3/port/in/PreSignedUrlUseCase.kt
@@ -1,7 +1,5 @@
 package site.yourevents.s3.port.`in`
 
-import site.yourevents.s3.vo.PreSignedUrlVO
-
 interface PreSignedUrlUseCase {
-    fun getPreSignedUrl(imageName: String): PreSignedUrlVO
+    fun getPreSignedUrl(imageName: String): String
 }
diff --git a/module-domain/src/main/kotlin/site/yourevents/s3/port/out/PreSignedUrlPort.kt b/module-domain/src/main/kotlin/site/yourevents/s3/port/out/PreSignedUrlPort.kt
@@ -1,7 +1,5 @@
 package site.yourevents.s3.port.out
 
-import site.yourevents.s3.vo.PreSignedUrlVO
-
 interface PreSignedUrlPort {
     fun getPreSignedUrl(imageName: String): String
 }
diff --git a/module-domain/src/main/kotlin/site/yourevents/s3/service/PreSignedUrlService.kt b/module-domain/src/main/kotlin/site/yourevents/s3/service/PreSignedUrlService.kt
@@ -1,19 +1,15 @@
 package site.yourevents.s3.service
 
 import jakarta.transaction.Transactional
-import org.springframework.context.annotation.ComponentScan
 import org.springframework.stereotype.Service
 import site.yourevents.s3.port.`in`.PreSignedUrlUseCase
 import site.yourevents.s3.port.out.PreSignedUrlPort
-import site.yourevents.s3.vo.PreSignedUrlVO
 
 @Service
 @Transactional
 class PreSignedUrlService(
     private val preSignedUrlPort: PreSignedUrlPort
 ) : PreSignedUrlUseCase {
-    override fun getPreSignedUrl(imageName: String): PreSignedUrlVO =
-        PreSignedUrlVO.from(
-            preSignedUrlPort.getPreSignedUrl(imageName)
-        )
+    override fun getPreSignedUrl(imageName: String): String =
+        preSignedUrlPort.getPreSignedUrl(imageName)
 }
diff --git a/module-domain/src/main/kotlin/site/yourevents/s3/vo/PreSignedUrlVO.kt b/module-domain/src/main/kotlin/site/yourevents/s3/vo/PreSignedUrlVO.kt
diff --git a/module-infrastructure/s3/src/main/resources/application.yml b/module-infrastructure/s3/src/main/resources/application.yml
diff --git a/module-presentation/src/main/kotlin/site/yourevents/s3/facade/PreSignedUrlFacade.kt b/module-presentation/src/main/kotlin/site/yourevents/s3/facade/PreSignedUrlFacade.kt
@@ -15,6 +15,6 @@ class PreSignedUrlFacade(
         preSignedUrlRequest: PreSignedUrlRequest
     ): PreSignedUrlResponse {
         val preSignedUrl = preSignedUrlUseCase.getPreSignedUrl(preSignedUrlRequest.imageName)
-        return PreSignedUrlResponse.of(preSignedUrl.preSignedUrl)
+        return PreSignedUrlResponse.of(preSignedUrl)
     }
 }
diff --git a/module-presentation/src/main/resources/application-local.yml b/module-presentation/src/main/resources/application-local.yml
@@ -1,4 +1,8 @@
 spring:
+  cloud:
+    aws:
+      region:
+        static: ap-northeast-2
   datasource:
     url: jdbc:mysql://localhost:3306/yourevents
     username: ${DB_USER}
@@ -52,3 +56,10 @@ logging:
     environment:  ${SENTRY_ENVIRONMENT}
   slack:
     webhook-url: ${SLACK_WEBHOOK_URL}
+
+aws:
+  s3:
+    accessKey: ${S3_ACCESS_KEY}
+    secretKey: ${S3_SECRET_KEY}
+    bucketName: ${S3_BUCKET}
+    region: ap-northeast-2