fix calculation of max size needed to hold tensors #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ankan-ban
commented
Jun 16, 2019
•
ankan-ban
commented
- kNumFilters can be smaller than kNumInputPlanes. We need to take max of them for computing sizes of intermediate buffers.
- for wdl, we need 3x the memory for holding value head output.
use bestmove_is_sent_ for Search::IsSearchActive() (LeelaChessZero#502)
get latest
get latest
get latest
get latest
Get latest
- replace all cudaMemcpyAsync used for loading weights with cudaMemcpy as source (in CPU memory) could be deleted before the async version of the function actually does the copy. - minor naming/style changes. - add comment explaining what the policy map layer does and how the layout conversion from CHW to HWC works.
get latest
get latest
get latest
get latest
- just add template instantiations. - verified that it works and provides a (very) slight speedup.
get latest
- no of filters can be less than no. of input planes!
- need 3x the size for wdl
Ttl
approved these changes
Jun 16, 2019
Tilps
reviewed
Jun 16, 2019
Tilps
approved these changes
Jun 16, 2019
|
Why does wdl change the policy head? |
|
It doesn't. I meant the value head. Updated description. |
Tilps
pushed a commit
that referenced
this pull request
Jul 21, 2019
* fix maxSize for tensor buffers - no of filters can be less than no. of input planes! * fix calculation for value head allocation too - need 3x the size for wdl * take max of all layers when computing size to avoid assumptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.