Add stop command to selfplay interactive mode to allow for graceful exit. #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tilps
commented
Mar 21, 2019
| @@ -85,6 +85,11 @@ void SelfPlayLoop::CmdStart() { | |||
| std::make_unique<std::thread>([this]() { tournament_->RunBlocking(); }); | |||
| } | |||
|
|
|||
| void SelfPlayLoop::CmdStop() { | |||
| tournament_->Stop(); | |||
| tournament_->Wait(); | |||
There was a problem hiding this comment.
This wait is here so you can issue stop/quit as a pair - and when the app has exited its done.
There was a problem hiding this comment.
"Nicer" solution would be stop+isready+quit, but selfplay is not real UCI anyway.
|
|
mooskagh
approved these changes
Mar 26, 2019
| @@ -85,6 +85,11 @@ void SelfPlayLoop::CmdStart() { | |||
| std::make_unique<std::thread>([this]() { tournament_->RunBlocking(); }); | |||
| } | |||
|
|
|||
| void SelfPlayLoop::CmdStop() { | |||
| tournament_->Stop(); | |||
| tournament_->Wait(); | |||
There was a problem hiding this comment.
"Nicer" solution would be stop+isready+quit, but selfplay is not real UCI anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't stop any games in progress as opposed to quit which terminates the app.
If we want to really aggressively go after short game bias we would also need to ensure each thread plays the same number of games, but at least with this in place we can look at migrating the client to use interactive mode to reduce short game bias. Every thread same number of games could be another flag in future.