Make appyeyor use the vs2017 compiler. #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooskagh
approved these changes
Dec 13, 2018
borg323
added a commit
to borg323/lc0
that referenced
this pull request
Jan 29, 2019
This reverts commit 6d61eb7.
borg323
added a commit
to borg323/lc0
that referenced
this pull request
Jan 29, 2019
This reverts commit 6d61eb7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests by @ankan-ban show it to be consistently faster than the previous version we were using. This may cause trouble next time appveyor updates the vs2017 image since the cuda headers still have compiler version checks. This post in the "Visual C++ Team Blog" states that "CUDA 10.0 will work with all the past and future updates of Visual Studio 2017" so let's see how this turns out.