ensure bestmove is sent when aborting search #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As suggested on discord, this is replaced by a change to the search destructor that now calls Abort() only when |
mooskagh
approved these changes
Nov 29, 2018
src/mcts/search.cc
Outdated
| @@ -644,7 +644,7 @@ void Search::Wait() { | |||
| } | |||
|
|
|||
| Search::~Search() { | |||
| Abort(); | |||
| if (!stop_.load(std::memory_order_acquire)) Abort(); | |||
There was a problem hiding this comment.
After some thought, I think it's even better to do that in Abort(). If stop_ is already true, just exit (maybe also output log message).
That way if Stop() was called before Abort(), stop wins. Otherwise Abort() wins.
But we don't have situations like this in the code now, so current way is totally fine too.
There was a problem hiding this comment.
I'm not sure which version I prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winboard with polyglot, when stopping pondering, sends the
positioncommand very quickly afterstopand then sendsgowhile at the same time waiting forbestmovebefore continuing. This leads to time losses: In some cases lc0 doesn't sendbestmoveat all when stopping, so the one sent after the finalgois taken to be the one afterstopand both sides end up waiting until time runs out.This ensures that a
bestmovewill always be sent when stopping the search (providedok_to_respond_bestmove_is true).