Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BACK-8208): tooling: Allow generation from string inputs #177

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

fsamier
Copy link
Contributor

@fsamier fsamier commented Jan 9, 2025

Breaking change

generate.generate_descriptor interface change: method now expects either string or bytes rather than path. Path should be resolved by caller.

generate_descriptor(chain_id=..., contract_address=..., abi_file="/path/to/abi.json")

Should be replaced by:

with open("/path/to/abi.json", "rb") as f:
   generate_descriptor(chain_id=..., contract_address=..., abi=f.read())

CLI is unchanged.

@fsamier fsamier requested a review from a team as a code owner January 9, 2025 16:31
@fsamier fsamier force-pushed the feat/generate-from-string branch from 0584000 to 2367963 Compare January 9, 2025 16:43
@fsamier fsamier changed the title Feat/generate-from-string feat(BACK-8208): tooling: Allow generation from string inputs Jan 9, 2025
@fsamier fsamier added the breaking Breaking change label Jan 10, 2025
@fsamier fsamier merged commit 78dd8d1 into main Jan 10, 2025
5 checks passed
@fsamier fsamier deleted the feat/generate-from-string branch January 10, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants