Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA] adding test - Default currency when landing on swap #9283

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[QAA] adding test - Default currency when landing on swap #9283

merged 1 commit into from
Feb 20, 2025
+70 −3

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Feb 19, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Adding test for swap:

  • Checking that the default currency is BTC when landing on swap for the first time
  • Checking that the default currency is the same as the set up previously established

❓ Context

✅ Allure

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 1:29pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 1:29pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 1:29pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 1:29pm

@VicAlbr VicAlbr marked this pull request as ready for review February 19, 2025 16:19
@VicAlbr VicAlbr requested review from a team as code owners February 19, 2025 16:19
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Feb 19, 2025
@VicAlbr VicAlbr requested a review from Copilot February 19, 2025 16:59
Copilot
Copilot AI reviewed Feb 19, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@VicAlbr VicAlbr enabled auto-merge February 20, 2025 13:48
@VicAlbr VicAlbr added this pull request to the merge queue Feb 20, 2025
Merged via the queue into develop with commit 1caf31c Feb 20, 2025
48 checks passed
@VicAlbr VicAlbr deleted the support/qaa-257 branch February 20, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

Assignees

@VicAlbr VicAlbr

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VicAlbr @ypolishchuk-ledger