Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› fix(llm) password crash on input focus #9281

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Feb 19, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Remove a race condition created but double auto focus that could lead to a crash

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 4:20pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 4:20pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 4:20pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 4:20pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 19, 2025
@VicAlbr VicAlbr requested a review from Copilot February 19, 2025 17:02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

apps/ledger-live-mobile/src/components/PasswordInput.tsx:81

  • The autoFocus prop might not work as intended since the ref is commented out. Consider re-enabling the ref or updating the implementation to ensure autoFocus works correctly.
autoFocus={autoFocus}
@LucasWerey LucasWerey marked this pull request as ready for review February 20, 2025 10:49
@LucasWerey LucasWerey requested a review from a team as a code owner February 20, 2025 10:49
@LucasWerey LucasWerey marked this pull request as draft February 20, 2025 11:20
@LucasWerey LucasWerey force-pushed the fix/LIVE-17107 branch 7 times, most recently from f898a4c to c023571 Compare February 21, 2025 14:51
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant