Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩 (llm/lld) update mev feature flag #9241

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Feb 14, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • lld settings
    • llm settings
    • mevProtection ff

πŸ“ Description

Update the Mev Protection feature flag to accept an url
On LLD I've updated directly SettingsRow component to keep the same archi and as I think it could be useful to have these params in the future
On LLM I've just sent a component as a description because it's more common on LLM

LLM LLD
https://github.com/user-attachments/assets/1c86dd4c-4536-4b70-9984-a4eddf7ae52b https://github.com/user-attachments/assets/d17207fa-55f9-450a-a062-d2012a805f4f

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Feb 14, 2025 5:28pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 5:28pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 5:28pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 5:28pm

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.4% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucasWerey LucasWerey added this pull request to the merge queue Feb 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025
@LucasWerey LucasWerey added this pull request to the merge queue Feb 17, 2025
Merged via the queue into develop with commit aa4e40c Feb 17, 2025
58 of 65 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-17051 branch February 17, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants