Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiversx rebranding bis #8757

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Multiversx rebranding bis #8757

wants to merge 1 commit into from

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented Dec 23, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 5:14pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:14pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:14pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:14pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli labels Dec 23, 2024
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Dec 23, 2024 •
edited
Loading

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data 3 Info
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 3 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@Wozacosta Wozacosta force-pushed the multiversx-rebranding-bis branch from 8937181 to bd3a9fc Compare December 23, 2024 16:12
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 23, 2024 •
edited
Loading

Mobile Bundle Checks

Comparing f8c5480 against e3a2abe.

🚀 main.ios.jsbundle bundle size decreased (62.4mb -> 62.3mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (62.4mb -> 62.3mb). Thanks ❤️

Desktop Bundle Checks

Comparing f8c5480 against e3a2abe.

✅ Previous issues have all been fixed.

@Wozacosta Wozacosta mentioned this pull request Dec 24, 2024
Closed
3 tasks
@Wozacosta Wozacosta force-pushed the multiversx-rebranding-bis branch from 89422aa to 6c1e2dc Compare January 2, 2025 09:29
@Wozacosta Wozacosta marked this pull request as ready for review January 2, 2025 15:40
@Wozacosta Wozacosta requested review from a team as code owners January 2, 2025 15:40
@Wozacosta Wozacosta force-pushed the multiversx-rebranding-bis branch from 8613260 to 52f0048 Compare February 12, 2025 15:49
qperrot
qperrot reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@qperrot qperrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple muted // multiversx

apps/cli/src/live-common-setup-base.ts Outdated
@@ -26,6 +26,7 @@ setSupportedCurrencies([
"dash",
"tron",
"tezos",
// "multiversx",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed ?

apps/ledger-live-desktop/src/live-common-set-supported-currencies.ts Outdated
@@ -35,6 +35,7 @@ setSupportedCurrencies([
"dash",
"tron",
"tezos",
// "multiversx",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remove ?

@Wozacosta Wozacosta force-pushed the multiversx-rebranding-bis branch from a5fd6c4 to e27f481 Compare February 14, 2025 08:56
qperrot
qperrot previously approved these changes Feb 14, 2025
View reviewed changes
ComradeAERGO
ComradeAERGO previously approved these changes Feb 17, 2025
View reviewed changes
@Wozacosta Wozacosta added this pull request to the merge queue Feb 17, 2025
@Wozacosta Wozacosta removed this pull request from the merge queue due to a manual request Feb 17, 2025
@Wozacosta Wozacosta added this pull request to the merge queue Feb 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025
@Wozacosta Wozacosta added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 18, 2025
@Wozacosta Wozacosta force-pushed the multiversx-rebranding-bis branch from e27f481 to 9aa520a Compare February 19, 2025 09:37
@popenta @Wozacosta
chore: rename elrond -> multiversx, fix import statements
0fc7846 
chore: update dependencies & update to latest core package
@Wozacosta Wozacosta force-pushed the multiversx-rebranding-bis branch from 9aa520a to 0fc7846 Compare February 19, 2025 17:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
15.3% Coverage on New Code (required ≥ 80%)
12.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Wozacosta Wozacosta enabled auto-merge February 19, 2025 19:04
@Wozacosta Wozacosta disabled auto-merge February 19, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canestin Canestin Canestin left review comments

@qperrot qperrot qperrot approved these changes

@ComradeAERGO ComradeAERGO ComradeAERGO approved these changes

@abdurrahman-ledger abdurrahman-ledger Awaiting requested review from abdurrahman-ledger

@cgrellard-ledger cgrellard-ledger Awaiting requested review from cgrellard-ledger

At least 1 approving review is required to merge this pull request.

Assignees

@Wozacosta Wozacosta

Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM Stale tools Has changes in tools translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Wozacosta @cgrellard-ledger @qperrot @ComradeAERGO @Canestin @abdurrahman-ledger @popenta