Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-3066: celo apdu test update #870

Merged
1 commit merged into from
Aug 9, 2022
Merged

LIVE-3066: celo apdu test update #870

1 commit merged into from
Aug 9, 2022

Conversation

henri-ly
Copy link
Contributor

@henri-ly henri-ly commented Aug 8, 2022

📝 Description

CELO Test apdu has not been up to date. this PR fix this

❓ Context

  • Impacted projects: live-common
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-3066

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Aug 8, 2022 at 3:58PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 8, 2022 at 3:58PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Aug 8, 2022 at 3:58PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Aug 8, 2022 at 3:58PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

⚠️ No Changeset found

Latest commit: a5970e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the common Has changes in live-common label Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #870 (a5970e1) into develop (538ce3a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #870   +/-   ##
========================================
  Coverage    47.56%   47.56%           
========================================
  Files          621      621           
  Lines        27841    27841           
  Branches      7148     7148           
========================================
+ Hits         13242    13243    +1     
- Misses       13471    13489   +18     
+ Partials      1128     1109   -19     
Flag Coverage Δ
test 47.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ø)
libs/ledgerjs/packages/hw-app-cosmos/src/Cosmos.ts 20.73% <0.00%> (ø)
.../ledgerjs/packages/hw-app-algorand/src/Algorand.ts 29.03% <0.00%> (ø)
.../ledgerjs/packages/hw-app-polkadot/src/Polkadot.ts 20.77% <0.00%> (ø)
...js/packages/hw-app-eth/src/services/ledger/nfts.ts 12.50% <0.00%> (ø)
...s/hw-transport-mocker/src/openTransportReplayer.ts 63.63% <0.00%> (ø)
...hw-transport-mocker/src/createTransportReplayer.ts 13.79% <0.00%> (ø)
libs/ledger-live-common/src/range.ts 97.43% <0.00%> (+2.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

@henrily-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ghost ghost merged commit d3d7c8d into develop Aug 9, 2022
@ghost ghost deleted the bugfix/LIVE-3066-celo-apdu branch August 9, 2022 08:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants