Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): ✍️ release correct memo/tag drawer copy #8639

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Dec 9, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Copy of the memo drawer

📝 Description

(This is the release PR for #8638).
The text of the drawer was the one of the receive flow which would have been misleading for users.

Before After
image image

Figma for reference

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner December 9, 2024 10:19
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:19am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:19am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:19am
web-tools ⬜️ Ignored (Inspect) Dec 9, 2024 10:19am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 9, 2024
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thesan thesan changed the title fix(llm): ✍️ correct memo/tag drawer copy fix(llm): ✍️ release correct memo/tag drawer copy Dec 9, 2024
@thesan thesan merged commit 8851e59 into release Dec 9, 2024
47 of 51 checks passed
@thesan thesan deleted the fix/llm-memo-tag-copy-release branch December 9, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants