Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (llm): onboarding analytics #8552

Merged
merged 1 commit into from
Dec 2, 2024
Merged

✨ (llm): onboarding analytics #8552

merged 1 commit into from
Dec 2, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Nov 29, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • reborn analytics

📝 Description

Enhance onBoarding analytics

onBoardingHasDevice => should change only if the user select it from onBoarding. If the user doesn't have a ledger during onboarding this will be false forever. If he has it will be true.

isReborn => I use readonly state to set it as it's the same mechanism

the medias are too big to be post here so refer to the ticket !

OnBoardingHasDevice : video

IsReborn : video

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 5:29pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 5:29pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 5:29pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 5:29pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 29, 2024
@LucasWerey LucasWerey marked this pull request as ready for review November 29, 2024 17:30
@LucasWerey LucasWerey requested a review from a team as a code owner November 29, 2024 17:30
@LucasWerey LucasWerey merged commit 0d7115c into develop Dec 2, 2024
48 of 56 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-14746 branch December 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants