Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ACRE): Remove fields from the sign-message modal type withdraw #8514

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

ComradeAERGO
Copy link
Contributor

@ComradeAERGO ComradeAERGO commented Nov 27, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Removing message fields from the sign-message modal type Withdraw, for the specific use case of ACRE withdrawals

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-15014


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:34am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:34am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:34am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 0:34am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Nov 27, 2024
@ComradeAERGO ComradeAERGO marked this pull request as ready for review November 28, 2024 12:24
@ComradeAERGO ComradeAERGO requested a review from a team as a code owner November 28, 2024 12:24
@ComradeAERGO ComradeAERGO force-pushed the feat/acre-remove-withdrawal-modal branch from c33f2cd to b8b9f76 Compare November 28, 2024 12:30
@ComradeAERGO ComradeAERGO merged commit 1df9b64 into develop Nov 28, 2024
52 of 53 checks passed
@ComradeAERGO ComradeAERGO deleted the feat/acre-remove-withdrawal-modal branch November 28, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants