Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› (llm) layout issue on my ledger screen #8509

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Nov 27, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    -My ledger screen

πŸ“ Description

Fix an extra margin at the bottom of my ledger screen

Before After
Simulator Screenshot - iPhone 15 - 2024-11-27 at 17 30 02 Simulator Screenshot - iPhone 15 - 2024-11-27 at 17 29 47
Simulator.Screen.Recording.-.iPhone.15.-.2024-11-27.at.17.33.24.mp4

❓ Context

  • JIRA or GitHub link: NOT NEEDED

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested review from a team as code owners November 27, 2024 16:30
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 27, 2024 4:30pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 27, 2024 4:30pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 27, 2024 4:30pm
web-tools ⬜️ Ignored (Inspect) Nov 27, 2024 4:30pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 27, 2024
@LucasWerey LucasWerey merged commit 9894ecc into develop Nov 27, 2024
54 of 56 checks passed
@LucasWerey LucasWerey deleted the fix/my_ledger_layout branch November 27, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants