feat: Rework hiddenCollections to handle more easily displays in LLM #8495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
themooneer
reviewed
Nov 27, 2024
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections-llm
branch
2 times, most recently
from
b42f3ad to
7bea312
Compare
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections
branch
2 times, most recently
from
4ebfc09 to
c10f439
Compare
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections-llm
branch
from
7bea312 to
c23451a
Compare
themooneer
previously approved these changes
Nov 29, 2024
mcayuelas-ledger
dismissed
themooneer’s stale review
The base branch was changed.
mcayuelas-ledger
force-pushed
the
feat/improve-hidden-collections-llm
branch
from
c23451a to
2fb5e08
Compare
ofreyssinet-ledger
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
hiddenCollectionsis now an object renamednftCollectionsStatusByNetwork, containing the different contracts according to their network3 types of status :
Spam => Spam filter automatically adds the contract to the object
Whitelisted => User manually removes contract from hiddenCollections
Blacklisted => User manually adds contract to hiddenCollections (Hide Collection)
FF-based display (nftFromSimpleHash) :
If ON => display only whitelisted NFTs in addition to others
If OFF => Whitelisted and Spam NFTs are displayed in addition to the others
Screen_Recording_20241127_105252_LL.DEV.mp4
❓ Context
🧐 Checklist for the PR Reviewers