Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 LLM - Improve Ledger Sync when backup deleted on multiple instances #8466

Merged
merged 2 commits into from
Dec 2, 2024
Merged

🐛 LLM - Improve Ledger Sync when backup deleted on multiple instances #8466

merged 2 commits into from
Dec 2, 2024

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Nov 25, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Ledger Sync

📝 Description

Improve the error message displayed when deleting backup on several instances at the same time

Before After
Screenshot_2024-11-25-15-12-58-61_99c1b3bb631177f8a9e1379ae5b12ffe Screenshot_2024-11-25-15-56-39-81_99c1b3bb631177f8a9e1379ae5b12ffe

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner November 25, 2024 15:07
@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:11pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:11pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:11pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 3:11pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Nov 25, 2024
@cgrellard-ledger cgrellard-ledger changed the title 🐛 LLM - Improve Ledger Sync when backup deleted on multiple instances 🐛 LLM - Improve Ledger Sync when backup deleted on multiple instances Nov 25, 2024
themooneer
themooneer previously approved these changes Nov 26, 2024
View reviewed changes
Base automatically changed from bugfix/llm-ls-error-message-when-delete-backup-and-sync to develop November 26, 2024 12:46
@cgrellard-ledger cgrellard-ledger dismissed stale reviews from mcayuelas-ledger and themooneer November 26, 2024 12:46

The base branch was changed.

@cgrellard-ledger cgrellard-ledger merged commit deb57d1 into develop Dec 2, 2024
41 of 45 checks passed
@cgrellard-ledger cgrellard-ledger deleted the bugfix/llm-ls-error-message-when-delete-backup-on-several-instances branch December 2, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

Assignees

@cgrellard-ledger cgrellard-ledger

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgrellard-ledger @themooneer @mcayuelas-ledger