Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (llm) add entry points for reborn LP variant A #8464

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Nov 25, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Reborn entry points

πŸ“ Description

Add reborn entry points :

  • Onboarding
  • Earn tab
  • My Ledger tab
  • banners
  • discovery apps
  • add assets
  • quick actions on asset page

Reborn is based on feature flag to defined what screen to render. In some cases it can happens there is nothing to render on corresponding landing page so we render the current screen.

fallback case :

Simulator.Screen.Recording.-.iPhone.15.-.2024-11-28.at.16.52.49.mp4

best case :

Simulator.Screen.Recording.-.iPhone.15.-.2024-11-28.at.16.59.41.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:28pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:28pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:28pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 3:28pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 25, 2024
@LucasWerey LucasWerey force-pushed the LIVE-14945 branch 18 times, most recently from 543066c to acb374a Compare November 28, 2024 16:40
@LucasWerey LucasWerey marked this pull request as ready for review November 29, 2024 18:12
@LucasWerey LucasWerey requested review from a team as code owners November 29, 2024 18:12
@LucasWerey LucasWerey merged commit 8cc1438 into develop Dec 2, 2024
40 of 41 checks passed
@LucasWerey LucasWerey deleted the LIVE-14945 branch December 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants