Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live 14434 sell card swap create exchange dev mode for llm #8389

Conversation

sergiubreban
Copy link
Contributor

@sergiubreban sergiubreban commented Nov 18, 2024

Add exchange dev mode in LLM.

Demo LLM(Android)

Screen.Recording.2024-11-18.at.14.22.41.mov

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:04pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:04pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:04pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:04pm

@sergiubreban sergiubreban requested review from a team as code owners November 18, 2024 13:29
@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common translations Translation files have been touched labels Nov 18, 2024
sarneijim
sarneijim previously approved these changes Nov 18, 2024
@sergiubreban sergiubreban force-pushed the LIVE-14434-sell-card-swap-create-exchange-dev-mode-for-llm branch from 57256e4 to 1b1b5f8 Compare November 22, 2024 07:24
Copy link
Contributor

@chrisduma-ledger chrisduma-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiubreban sergiubreban merged commit 995b771 into develop Dec 2, 2024
55 checks passed
@sergiubreban sergiubreban deleted the LIVE-14434-sell-card-swap-create-exchange-dev-mode-for-llm branch December 2, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants