Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 💄Skip drawer when user clicks on delete Sync #7849

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Sep 19, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • [] Impact of the changes:
    • ...

📝 Description

Skip drawer when user clicks on delete Sync + update copy on this flow

DeletKey.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner September 19, 2024 09:23
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:21am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:21am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:21am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:21am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 10:21am

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Sep 19, 2024
LucasWerey
LucasWerey previously approved these changes Sep 19, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 75e8548 into develop Sep 19, 2024
41 of 42 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/update-ledgerSync-managekey branch September 19, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants