fix: 🐛 Fix Blank account screen when removing account from LLD when LS activated #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
cgrellard-ledger
approved these changes
Sep 17, 2024
LucasWerey
approved these changes
Sep 17, 2024
themooneer
reviewed
Sep 17, 2024
| }, | ||
| }); | ||
| } | ||
| }, [account, navigation]); | ||
| if (!account) return null; |
There was a problem hiding this comment.
question: would you keep this ligne while you already navigate to another screen (so this component will explicitly unmount) in the useEffect ?
There was a problem hiding this comment.
Type 'AccountLike | undefined' is not assignable to type 'AccountLike'. Type 'undefined' is not assignable to type 'AccountLike'.
if I remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Fix Blank account screen when removing account from LLD when LS activated
Screen.Recording.2024-09-17.at.11.59.02.mov
❓ Context
🧐 Checklist for the PR Reviewers