✨(llm/lld): add dynamic learn more for LS activation #7825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
desktop
LucasWerey
force-pushed
the
feat/LIVE-14081-14082
branch
from
7b9437d
to
15bc8ba
Compare
LucasWerey
force-pushed
the
feat/LIVE-14081-14082
branch
from
15bc8ba
to
bf5b91e
Compare
mcayuelas-ledger
requested changes
Sep 17, 2024
Comment on lines
13
to
14
| onPressLearnMore: () => void; | ||
| hasLearnMoreLink?: boolean; |
There was a problem hiding this comment.
You can simplify just by onPressLearnMore as optional ?
themooneer
reviewed
Sep 17, 2024
|
|
||
| useInitMemberCredentials(); | ||
|
|
||
| const onPressSyncAccounts = () => onSyncMethodPress(); | ||
|
|
||
| const onPressHasAlreadyCreatedAKey = () => onSyncMethodPress(); | ||
|
|
||
| const onPressLearnMore = () => learnMoreLink && Linking.openURL(learnMoreLink); |
There was a problem hiding this comment.
you may have an eslint problem here for no-unused-expressions rule. For a better readability and code maintainability the better is to use an if bloc and invoke your openURL function there.
themooneer
reviewed
Sep 17, 2024
| const learnMoreUrl = ledgerSyncFF?.params?.learnMoreLink; | ||
| const hasLearnMoreLink = !!learnMoreUrl; | ||
|
|
||
| const onLearnMore = () => hasLearnMoreLink && openURL(learnMoreUrl); |
There was a problem hiding this comment.
LucasWerey
force-pushed
the
feat/LIVE-14081-14082
branch
2 times, most recently
from
be38291
to
f400a03
Compare
Changed for
|
themooneer
previously approved these changes
Sep 17, 2024
mcayuelas-ledger
previously approved these changes
Sep 17, 2024
LucasWerey
dismissed stale reviews from mcayuelas-ledger and themooneer
via
8d2dd0d
LucasWerey
force-pushed
the
feat/LIVE-14081-14082
branch
from
f400a03
to
8d2dd0d
Compare
mcayuelas-ledger
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Add a field to the feature flag so we can dynamically change the learn more url when activate ledger sync.
The learmore link will appears only if a value is provided
The UI has changed on both LLD and LLM
Good and bad case integration tests added
The new field is
learnMoreLinkLLD :
https://github.com/user-attachments/assets/92fae350-6a76-4b0f-920c-efbfa6aeb3e9
LLM :
https://github.com/user-attachments/assets/bc0fec2d-8b05-4673-aa08-33feb6ec6eaf
❓ Context
🧐 Checklist for the PR Reviewers