🐛fix(lld): fix export to csv account name #7813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
desktop
mcayuelas-ledger
requested changes
Sep 13, 2024
| @@ -65,7 +67,10 @@ const fields: Field[] = [ | |||
| { | |||
| title: "Account Name", | |||
| // FIXME: we need to inject wallet state if we want the actual user's account name | |||
| cell: (account, parentAccount) => getDefaultAccountName(getMainAccount(account, parentAccount)), | |||
| cell: (account, parentAccount, _op, _counterValueCurrency, _countervalueState, walletState) => | |||
There was a problem hiding this comment.
why do we need this 3 ? _op, _counterValueCurrency, _countervalueState
There was a problem hiding this comment.
Because how it's done today if walletState is at the third place it would be the operation
LucasWerey
force-pushed
the
fix/LIVE-14076
branch
from
a9caf30
to
cdeb11f
Compare
mcayuelas-ledger
approved these changes
Sep 13, 2024
| @@ -65,7 +67,10 @@ const fields: Field[] = [ | |||
| { | |||
| title: "Account Name", | |||
| // FIXME: we need to inject wallet state if we want the actual user's account name | |||
| cell: (account, parentAccount) => getDefaultAccountName(getMainAccount(account, parentAccount)), | |||
| cell: (account, parentAccount, _op, _counterValueCurrency, _countervalueState, walletState) => | |||
themooneer
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Accounts names were not exported in the csv it's now fixed.
❓ Context
🧐 Checklist for the PR Reviewers