Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Fix/turborepo 2 upgrade from scratch 2 #7787

Closed
wants to merge 10 commits into from

Conversation

angusbayley
Copy link
Contributor

CI development/test PR, for work on #7769. Not to be merged

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

BREAKING CHANGE: upgraded turborepo to version 2, which includes breaking changes in the build process and configuration.
temp: add logging in turbo-affected

temp: hardcode the turbo version in turbo-affected

temp: hardcode the turbo version in the npx cmd

temp: rebuild affected action

temp: now get turbo version from package - keep logs in to observe it passed through

temp: remove logging
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 2:12pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 2:12pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 2:12pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 2:12pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 2:12pm

@live-github-bot live-github-bot bot added ui Has changes in the design system library tools Has changes in tools automation CI/CD stuff labels Sep 10, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/turbo@2.1.1 None 0 14.9 kB turbobot

🚮 Removed packages: npm/turbo@1.10.1

View full report↗︎

@KVNLS KVNLS deleted the fix/turborepo-2-upgrade-from-scratch-2 branch September 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff tools Has changes in tools ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant